always create a 32x32 image, even if application.current is null#3725
Merged
always create a 32x32 image, even if application.current is null#3725
Conversation
dominoFire
approved these changes
Oct 21, 2020
.../NuGet.Clients.Tests/NuGet.PackageManagement.UI.Test/Models/PackageItemListViewModelTests.cs
Outdated
Show resolved
Hide resolved
donnie-msft
approved these changes
Oct 21, 2020
Contributor
donnie-msft
left a comment
donnie-msft
left a comment
There was a problem hiding this comment.
Is the Application.Current sometimes being null flaky, or is it dependent on the test scenario whether it's loaded? If flaky, we should track an issue for understanding why
Contributor
Author
it is depending on whether other tests run before it or not, etc... i believe. |
dtivel
approved these changes
Oct 21, 2020
erdembayar
approved these changes
Oct 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/nuget/client.engineering/issues/603
Regression: no
Fix
Details: tests sometimes run with application.current not null, sometimes not. make tests handle both cases.
Testing/Validation
Tests Added: no
Reason for not adding tests: tweaking the new ones i had as part of feature work
Validation: ran unit tests in VS. Then CI.